Skip to content

BREAKING CHANGE(https): migrate ca, cert, pfx, key, pfx-passphrase, and requestCert to https object #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2020
Merged

BREAKING CHANGE(https): migrate ca, cert, pfx, key, pfx-passphrase, and requestCert to https object #2564

merged 2 commits into from
May 5, 2020

Conversation

@hiroppy
Copy link
Member

@hiroppy hiroppy commented May 3, 2020 •
edited
Loading

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Migrate ca, cert, pfx, key, pfx-passphrase, and requestCert to https object.
These options are deleted from CLI.(accept https only

}
  https: {
    ca: string | Buffer;
    key: string | Buffer;
    pfx: string | Buffer;
    cert: string | Buffer;
    passphrase: string;
    requestCert: boolean;
  }
}

Breaking Changes

yes

Additional Info

@codecov
Copy link

codecov bot commented May 3, 2020 •
edited
Loading

Codecov Report

Merging #2564 into v4 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2564   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          34       34           
  Lines        1309     1295   -14     
  Branches      369      363    -6     
=======================================
- Hits         1223     1210   -13     
+ Misses         83       82    -1     
  Partials        3        3
Impacted Files Coverage Δ
lib/utils/createConfig.js 95.78% <ø> (-0.41%) ⬇️
lib/Server.js 96.92% <100.00%> (+0.19%) ⬆️
lib/utils/addEntries.js 100.00% <100.00%> (ø)
lib/utils/routes.js 92.30% <100.00%> (ø)
lib/utils/updateCompiler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308ee21...3a3aea3. Read the comment docs.

alexander-akait
alexander-akait approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Loonride

@knagaitsev knagaitsev self-requested a review May 4, 2020 23:12
knagaitsev
knagaitsev requested changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@knagaitsev knagaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack-dev-server/test/cli/cli.test.js

Line 76 in 375ab23

it('--https --cacert --pfx --key --cert --pfx-passphrase', (done) => {

We don't need this test. Also, has it always been the case that the CLI can run with unknown args?

@hiroppy
Copy link
Member Author

hiroppy commented May 5, 2020

We always accept any args like this.

$ npm run webpack-dev-server -- -a

> webpack-dev-server@3.10.3 webpack-dev-server /Users/hiroppy/webpack/webpack-dev-server
> node examples/run-example.js "-a"

And this test is poor.

@hiroppy
Copy link
Member Author

hiroppy commented May 5, 2020

@Loonride PTAL

@hiroppy hiroppy merged commit 05d0a2b into v4 May 5, 2020
@hiroppy hiroppy deleted the feature/modify-https branch May 5, 2020 02:40
alexander-akait pushed a commit that referenced this pull request May 8, 2020
@hiroppy @alexander-akait
BREAKING CHANGE(https): migrate ca, cert, pfx, key, pfx-passphrase, a…
7cd576a 
…nd requestCert to https object (#2564)
@ylemkimon ylemkimon mentioned this pull request Nov 27, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@knagaitsev knagaitsev knagaitsev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hiroppy @alexander-akait @knagaitsev